Skip to content

fix(info): do not raise the buttons above the navigation bar - #21586

Merged
lukstbit merged 1 commit into
ankidroid:mainfrom
criticalAY:fix/info-buttons-raised
Aug 24, 2026
Merged

fix(info): do not raise the buttons above the navigation bar#21586
lukstbit merged 1 commit into
ankidroid:mainfrom
criticalAY:fix/info-buttons-raised

Conversation

@criticalAY

Copy link
Copy Markdown
Contributor

Purpose / Description

We don't need bottom button clearance here sorry about that so updating the code and test

Fixes

Approach

ref commit

How Has This Been Tested?

image

Learning (optional, can help others)

Mistakes happen :)

Checklist

Please, go through these checks before submitting the PR.

  • You have a descriptive commit message with a short title (first line, max 50 chars).
  • You have commented your code, particularly in hard-to-understand areas
  • You have performed a self-review of your own code
  • UI changes: include screenshots of all affected screens (in particular showing any new or changed strings)
  • UI Changes: You have tested your change using the Google Accessibility Scanner

@criticalAY criticalAY added the Review High Priority Request for high priority review label Aug 24, 2026
@github-actions

Copy link
Copy Markdown
Contributor

Snapshot diff report vs main. Open screenshot-diff for diffs.

  • InfoScreenshotTest: 1 change
All 1 changed screenshots

InfoScreenshotTest

  • gesture_navigation_compare.png

@david-allison david-allison left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

I had Fable give it a shot, and it defined a new bottomCornerClearance method which took a margin parameter.

I prefer this approach - less generic, but much simpler to understand.

@david-allison david-allison added Needs Second Approval Has one approval, one more approval to merge and removed Needs Review labels Aug 24, 2026
@lukstbit lukstbit added Pending Merge Things with approval that are waiting future merge (e.g. targets a future release, CI wait, etc) and removed Needs Second Approval Has one approval, one more approval to merge labels Aug 24, 2026
@lukstbit
lukstbit added this pull request to the merge queue Aug 24, 2026
Merged via the queue into ankidroid:main with commit 541ca21 Aug 24, 2026
24 of 25 checks passed
@github-actions github-actions Bot removed Review High Priority Request for high priority review Pending Merge Things with approval that are waiting future merge (e.g. targets a future release, CI wait, etc) labels Aug 24, 2026
@github-actions github-actions Bot added this to the 2.25 release milestone Aug 24, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] Buttons on the 'Info' screen have been raised

3 participants